Re: SQL:2011 application time

On Mon, Sep 06, 2021 at 12:52:37PM -0700, Paul A Jungwirth wrote:
> On Sat, Sep 4, 2021 at 12:56 PM Jaime Casanova
> <jcasanov(at)systemguards(dot)com(dot)ec> wrote:
> >
> > patch 01: does apply but doesn't compile, attached the compile errors.
> > patch 04: does not apply clean.
>
> Thanks for taking a look! I've rebased & made it compile again. v7 attached.
>

patch 01: does apply but gives a compile warning (which is fixed by patch
02)
"""
parse_utilcmd.c: In function ‘generateClonedIndexStmt’:
parse_utilcmd.c:1730:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
Period *p = makeNode(Period);
^~~~~~
"""

patch 03: produces these compile errors.

analyze.c: In function ‘transformForPortionOfBound’:
analyze.c:1171:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
A_Const *n2 = makeNode(A_Const);
^~~~~~~
analyze.c:1172:10: error: ‘union ValUnion’ has no member named ‘type’
n2->val.type = T_Null;
^
analyze.c:1172:18: error: ‘T_Null’ undeclared (first use in this function)
n2->val.type = T_Null;
^~~~~~
analyze.c:1172:18: note: each undeclared identifier is reported only once for each function it appears in

--
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL