Re: when the startup process doesn't (logging startup delays)

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: when the startup process doesn't (logging startup delays)
Date: 2021-09-04 02:23:27
Message-ID: 20210904022327.GE26465@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 03, 2021 at 01:23:56PM +0530, Nitin Jadhav wrote:
> Please find the updated patch attached.

Please check CA+TgmoZtbqxaOLdpNkBcDbz=41tWALA8kpH4M=RWtPYHC7-KNg(at)mail(dot)gmail(dot)com

I agree with Robert that a standby server should not continuously show timing
messages for WAL replay.

Some doc comments:

+ Sets the time interval between each progress update of the operations
+ performed during startup process. This produces the log message after

Either say "performed by the startup process" or "performed during startup".

s/the/a/

+ every interval of time for the operations that take longer time. The unit

..for those operations which take longer than the specified duration.

+ used to specify the value is seconds. For example, if you set it to
+ <literal> 10s </literal>, then after every <literal> 10s </literal> there

remove "after"

+ is a log message indicating which operation is going on and what is the

say "..every 10s, a log is emitted indicating which operation is ongoing, and
the elapsed time from the beginning of the operation.."

+ elapsed time from beginning. If the value is set to <literal> 0 </literal>,
+ then it logs all the available messages for such operations. <literal> -1

"..then all messages for such operations are logged."

+ </literal> disables the feature. The default value is set to <literal> 10s
+ </literal>

"The default value is >10s<."

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-09-04 03:24:32 Re: Skipping logical replication transactions on subscriber side
Previous Message Tom Lane 2021-09-04 01:06:15 Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters