|From:||Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>|
|To:||Arne Roland <A(dot)Roland(at)index(dot)de>|
|Cc:||vignesh C <vignesh21(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: Rename of triggers for partitioned tables|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2021-Jul-19, Alvaro Herrera wrote:
> Well, it does rename a trigger named 'name' on the table 'table_name',
> as well as all its descendant triggers. I guess I am surprised that
> anybody would rename a descendant trigger in the first place. I'm not
> wedded to the decision of removing the NOTICE, though ... are there any
> other votes for that, anyone?
I put it back, mostly because I don't really care and it's easily
removed if people don't want it. (I used a different wording though,
not necessarily final.)
I also realized that if you rename a trigger and the target name is
already occupied, we'd better throw a nicer error message than failure
by violation of a unique constraint; so I moved the check for the name
to within renametrig_internal(). Added a test for this.
Also added a test to ensure that nothing happens with statement
triggers. This doesn't need any new code, because those triggers don't
have tgparentid set.
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
|Next Message||Tomas Vondra||2021-07-20 20:27:09||Re: logical decoding and replication of sequences|
|Previous Message||Filip Gospodinov||2021-07-20 20:04:02||Re: Fix pkg-config file for static linking|