Re: Bracket, brace, parenthesis

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: michael(at)paquier(dot)xyz
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Bracket, brace, parenthesis
Date: 2021-05-28 06:25:40
Message-ID: 20210528.152540.1337913142389747325.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Thu, 27 May 2021 21:08:46 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Thu, May 27, 2021 at 03:20:10PM +0900, Kyotaro Horiguchi wrote:
> > At Fri, 14 May 2021 10:04:57 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
> >> +1. I tend to write "square bracket" or "curly brace" when I want to
> >> be extra clear, but I think the bare terms are widely understood to
> >> have those meanings.
> >
> > Thanks! I think the message is new in 14 so we can fix it right
> > away. The attached is the version with a commit message added.
>
> No objections from me to fix that on HEAD now for clarity, let's wait
> a bit and see if others have more comments. You have missed an update
> of multirangetypes.out, by the way.

Mmm. Thanks. So the test doesn't a check for the case of trailing
garbage. Looking the discussion about trailing garbage of interger
values, we might need one for the case.

The atached second file adds a test for trailing garbage for
multirangetype.sql and rangetype.sql.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v2-0001-Change-confusing-bracket-use-to-clearer-wording.patch text/x-patch 2.2 KB
v2-0002-Add-test-cases-for-trailing-garbage-of-multi-rang.patch text/x-patch 2.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message torikoshia 2021-05-28 06:51:37 Re: RFC: Logging plan of the running query
Previous Message Amit Kapila 2021-05-28 06:25:38 Re: [HACKERS] logical decoding of two-phase transactions