Re: PG 14 release notes, first draft

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG 14 release notes, first draft
Date: 2021-05-10 17:47:24
Message-ID: 20210510174724.GJ6088@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 10, 2021 at 07:39:17PM +0200, Laurenz Albe wrote:
> On Mon, 2021-05-10 at 12:38 -0400, Bruce Momjian wrote:
> > I came up with this release note text:
> >
> > <listitem>
> > <!--
> > Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> > 2021-04-03 [55873a00e] Improve psql's behavior when the editor is exited withou
> > -->
> >
> > <para>
> > When editing the previous query or a file with psql's \e, ignore the
> > contents if the editor exits without saving (Laurenz Albe)
> > </para>
> >
> > <para>
> > Previously, editing the previous query or a file and not saving the
> > editor contents would still execute the editor contents. The \ef and
> > \ev commands also now have this behavior.
> > </para>
> > </listitem>
>
> Thanks, that looks much better.
>
> The second paragraph starts describing the previous behavior, but the second
> sentence details on the changes. Perhaps it would be better to put that into
> the first paragraph:
>
> <para>
> When editing the previous query or a file with psql's \e, or when a
> view or function definition are edited with \ev or \ef, ignore the
> contents if the editor exits without saving (Laurenz Albe)
> </para>
>
> <para>
> Previously, editing the previous query or a file and not saving the
> editor contents would still execute the editor contents.
> </para>

Uh, I try to keep the first sentence short so people can scan it more
easily, so I am hesitant to make this change. I went with this change:

<listitem>
<!--
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2021-04-03 [55873a00e] Improve psql's behavior when the editor is exited withou
-->

<para>
When editing the previous query or a file with psql's \e, or using \ef and \ev, ignore the contents if the editor exits without saving (Laurenz Albe)
</para>

<para>
Previously, such edits would still execute the editor contents.
</para>
</listitem>

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-05-10 18:06:16 Re: Reducing opr_sanity test's runtime under CLOBBER_CACHE_ALWAYS
Previous Message Andres Freund 2021-05-10 17:44:45 Re: Reducing opr_sanity test's runtime under CLOBBER_CACHE_ALWAYS