Re: libpq debug log

From: "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org>
To: "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>
Cc: "iwata(dot)aya(at)fujitsu(dot)com" <iwata(dot)aya(at)fujitsu(dot)com>, 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: libpq debug log
Date: 2021-03-27 19:28:12
Message-ID: 20210327192812.GA25115@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2021-Mar-26, alvherre(at)alvh(dot)no-ip(dot)org wrote:

> Proposed changes on top of v29.

This last one uses libpq_pipeline -t and verifies the output against an
expected trace file. Applies on top of all the previous patches. I
attach the whole lot, so that the CF bot has a chance to run it.

I did notice another problem for comparison of expected trace files,
which is that RowDescription includes table OIDs for some columns. I
think we would need to have a flag to suppress that too, somehow,
although the answer to what should we do is not as clear as for the
other two cases.

I dodged the issue by just using -t for the pipeline cases that don't
have OIDs in their output. This leaves us with no coverage for the
ErrorResponse message, which I think is a shortcoming. If we fixed the
OID problem and the ErrorResponse problem, we could add an expected
trace for pipeline_abort. I think we should do that.

Maybe the easiest way is to have a new flag PQTRACE_REGRESS_MODE.

Álvaro Herrera 39°49'30"S 73°17'W
Essentially, you're proposing Kevlar shoes as a solution for the problem
that you want to walk around carrying a loaded gun aimed at your foot.
(Tom Lane)

Attachment Content-Type Size
v30-0001-libpq-trace-v29.patch text/x-diff 27.7 KB
v30-0002-libpq_pipeline-add-t-support-for-PQtrace.patch text/x-diff 4.6 KB
v30-0003-put-FILE-arg-always-first.patch text/x-diff 18.5 KB
v30-0004-use-F-B-instead-of.patch text/x-diff 782 bytes
v30-0005-pass-cursor-to-printing-routines.patch text/x-diff 17.5 KB
v30-0006-add-length-check.patch text/x-diff 968 bytes
v30-0007-Use-libpq_pipeline-to-test-PQtrace.patch text/x-diff 6.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-03-27 20:01:08 Re: [HACKERS] GSoC 2017: Foreign Key Arrays
Previous Message Tom Lane 2021-03-27 18:11:13 Re: making update/delete of inheritance trees scale better