Re: Using COPY FREEZE in pgbench

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: coelho(at)cri(dot)ensmp(dot)fr
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Using COPY FREEZE in pgbench
Date: 2021-03-21 06:10:15
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>> V3 works for me and looks ok. I changed it to ready in the CF app.
> Thank you for your review!

Unfortunately it seems cfbot is not happy with the patch.

# Failed test 'pgbench scale 1 initialization status (got 1 vs expected 0)'
# at t/ line 116.
# Failed test 'pgbench scale 1 initialization stderr /(?^:creating foreign keys)/'
# at t/ line 116.
# 'dropping old tables...
# creating tables...
# creating 2 partitions...
# creating primary keys...
# vacuuming...
# generating data (client-side)...
# 100000 of 100000 tuples (100%) done (elapsed 0.02 s, remaining 0.00 s)
# ERROR: cannot perform COPY FREEZE on a partitioned table
# pgbench: fatal: PQendcopy failed

I think pgbench needs to check whether partitioning option is
specified or not. If specified, pgbench should not use COPY
FREEZE. Attached v4 patch does this.

Best regards,
Tatsuo Ishii
SRA OSS, Inc. Japan

Attachment Content-Type Size
pgbench_freeze_v4.diff text/x-patch 2.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2021-03-21 06:39:31 Re: new release pspg
Previous Message Dilip Kumar 2021-03-21 05:22:14 Re: [HACKERS] Custom compression methods (mac+lz4.h)