From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
---|---|
To: | coelho(at)cri(dot)ensmp(dot)fr |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Using COPY FREEZE in pgbench |
Date: | 2021-03-20 23:26:48 |
Message-ID: | 20210321.082648.773130439756064775.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Fabien,
> Hello Tatsuo-san,
>
>>> I have looked in the code of PQprotocolVersion. The only case in which
>>> it returns 0 is there's no connection. Yes, you are right. Once the
>>> connection has been successfuly established, there's no chance it
>>> fails. So I agree with you.
>>
>> Attached v3 patch addresses this.
>>
>>>> The "g" item in the section describing initialization steps
>>>> (i.e. option -I). I'd suggest just to replace "COPY" with "COPY
>>>> FREEZE" in the sentence.
>>>
>>> Ok. The section is needed to be modified.
>>
>> This is also addressed in the patch.
>
> V3 works for me and looks ok. I changed it to ready in the CF app.
Thank you for your review!
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2021-03-20 23:30:18 | Re: [HACKERS] Custom compression methods |
Previous Message | Justin Pryzby | 2021-03-20 23:20:39 | Re: [HACKERS] Custom compression methods |