Re: [HACKERS] PATCH: Batch/pipelining support for libpq

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, Matthieu Garrigues <matthieu(dot)garrigues(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Subject: Re: [HACKERS] PATCH: Batch/pipelining support for libpq
Date: 2021-03-11 16:00:13
Message-ID: 20210311160013.GA13683@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2021-Mar-05, Alvaro Herrera wrote:

> I'll take the weekend to think about the issue with conn->last_query and
> conn->queryclass that I mentioned yesterday; other than that detail my
> feeling is that this is committable, so I'll be looking at getting this
> pushed early next weeks, barring opinions from others.

It took longer than I expected, but it works well now. conn->last_query
is gone; all commands, both in pipeline mode and in no-pipeline mode, go
via the command queue. This is cleaner all around; we don't have to
have the pipeline code "cheat" so that it looks like each command is
"last" at each point.

I have not absorbed David Johnston's latest doc suggestions yet.

I'm going to give the code a last renaming pass, on the idea that the
command queue is no longer exclusively for the pipeline mode, so some
things need less exclusionary names. But functionality wise AFAICS this
patch has the shape it ought to have.

Álvaro Herrera 39°49'30"S 73°17'W

Attachment Content-Type Size
v35-libpq-pipeline.patch text/x-diff 110.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2021-03-11 16:06:36 Re: Autovacuum on partitioned table (autoanalyze)
Previous Message Gilles Darold 2021-03-11 15:50:48 Re: MultiXact\SLRU buffers configuration