Re: Prevent printing "next step instructions" in initdb and pg_upgrade

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Prevent printing "next step instructions" in initdb and pg_upgrade
Date: 2021-02-07 14:50:14
Message-ID: 20210207145014.GA18363@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 7, 2021 at 11:21:05AM +0100, Magnus Hagander wrote:
> > It appears that there is an extra blank line in the initdb output before
> > "Success" now.
>
> Oops, clearly it does.
>
> That said, the full output is:
>
> """
> Success. You can now start the database server using:
>
> bin/pg_ctl -D /tmp/data -l logfile start
>
>
> Success.
> """
>
> Isn't the whole "Success." at the end redundant here, and we should
> just end the message after the pg_ctl command? So not just the extra
> newline, but the whole thing?

Agreed.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2021-02-07 15:59:04 Re: jsonb_array_elements_recursive()
Previous Message Mark Rofail 2021-02-07 14:10:28 Re: [HACKERS] GSoC 2017: Foreign Key Arrays