Re: pg_upgrade test for binary compatibility of core data types

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, buschmann(at)nidsa(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade test for binary compatibility of core data types
Date: 2021-01-11 15:21:36
Message-ID: 20210111152136.GB4320@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, Jan 11, 2021 at 03:28:08PM +0100, Peter Eisentraut wrote:
> On 2020-12-27 20:07, Justin Pryzby wrote:
> > rebased on 6df7a9698bb036610c1e8c6d375e1be38cb26d5f
>
> I think these patches could use some in-place documentation of what they are
> trying to achieve and how they do it. The required information is spread
> over a lengthy thread. No one wants to read that. Add commit messages to
> the patches.

Oh, I see that now, and agree that you need to explain each item with a
comment. pg_upgrade is doing some odd things, so documenting everything
it does is a big win.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2021-01-11 15:55:30 Re: BUG #16817: kill process cause postmaster hang
Previous Message PG Bug reporting form 2021-01-11 15:10:42 BUG #16817: kill process cause postmaster hang

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2021-01-11 16:13:54 Re: popcount
Previous Message Tom Lane 2021-01-11 15:15:52 Re: Multiple hosts in connection string failed to failover in non-hot standby mode