Re: Context diffs

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Context diffs
Date: 2021-01-05 17:56:05
Message-ID: 20210105175605.GL7432@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 4, 2021 at 02:42:16PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Our developer FAQ mentions context diffs in several places for their
> > improved readability:
> > https://wiki.postgresql.org/wiki/Developer_FAQ
>
> I think that's kind of out of date; AFAIK the majority of hackers
> think -u format is more readable. (For myself, I've gotten better
> at reading -u format, but I still find it illegible for complex
> changes. Still, I try to always post patches in -u format to
> defer to the majority.)

OK, I removed the mention of "context" diffs from the developer FAQ.
I think I will produce unified diffs going forward, for the reasons
mentioned.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-01-05 17:58:16 Re: Context diffs
Previous Message Bruce Momjian 2021-01-05 17:51:08 Re: set_config() documentation clarification