| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add key management system |
| Date: | 2020-12-25 19:41:25 |
| Message-ID: | 20201225194125.GC19054@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Dec 25, 2020 at 02:37:06PM -0500, Tom Lane wrote:
> I wrote:
> > Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> >> I think cipher_failure() should be marked pg_attribute_noreturn().
>
> > Perhaps more to the point, it still doesn't build at all without
> > --with-openssl.
>
> [ looks closer ... ] Oh, we're on about the same thing -- the difference
> is that sifaka is using -Werror.
>
> pg_attribute_noreturn() seems like a good idea, but we're also going to
> need dummy return statements in the callers, to satisfy compilers that
> don't understand that.
Yes, done. I tested it with a non-OpenSSL configure run now and it
worked. Thanks for the report.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-12-25 19:46:11 | pgsql: Really fix the dummy implementations in cipher.c. |
| Previous Message | Bruce Momjian | 2020-12-25 19:40:58 | pgsql: fix no-return function call in cipher.c from commit 978f869b99 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-12-25 19:53:10 | Re: pgsql: Add key management system |
| Previous Message | Tom Lane | 2020-12-25 19:37:06 | Re: pgsql: Add key management system |