Re: pgsql: Add key management system

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add key management system
Date: 2020-12-25 19:37:06
Message-ID: 1177207.1608925026@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
>> I think cipher_failure() should be marked pg_attribute_noreturn().

> Perhaps more to the point, it still doesn't build at all without
> --with-openssl.

[ looks closer ... ] Oh, we're on about the same thing -- the difference
is that sifaka is using -Werror.

pg_attribute_noreturn() seems like a good idea, but we're also going to
need dummy return statements in the callers, to satisfy compilers that
don't understand that.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-25 19:40:58 pgsql: fix no-return function call in cipher.c from commit 978f869b99
Previous Message Tom Lane 2020-12-25 19:17:10 Re: pgsql: Add key management system

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2020-12-25 19:41:25 Re: pgsql: Add key management system
Previous Message Noah Misch 2020-12-25 19:24:37 Re: Temporary tables versus wraparound... again