Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, James Coleman <jtc331(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Re: "as quickly as possible" (was: remove spurious CREATE INDEX
> On 2020-Nov-23, Tom Lane wrote: > > > Here's a draft patch. > > Here's another of my own. Outside of elog.c it seems identical.
Your version has the advantage that errstart() doesn't get a new function call. I'm +1 for going with that ... we could avoid the duplicate code with some additional contortions but this changes so rarely that it's probably not worth the trouble.