| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, James Coleman <jtc331(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait) |
| Date: | 2020-11-23 22:48:23 |
| Message-ID: | 197305.1606171703@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Your version has the advantage that errstart() doesn't get a new
> function call. I'm +1 for going with that ... we could avoid the
> duplicate code with some additional contortions but this changes so
> rarely that it's probably not worth the trouble.
I was considering adding that factorization, but marking the function
inline to avoid adding overhead. Most of elog.c predates our use of
inline, so it wasn't considered when this code was written.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2020-11-23 23:00:31 | Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*) |
| Previous Message | Tom Lane | 2020-11-23 22:45:20 | Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait) |