Re: Add statistics to pg_stat_wal view for wal related parameter tuning

From: "lchch1990(at)sina(dot)cn" <lchch1990(at)sina(dot)cn>
To: "Masahiro Ikeda" <ikedamsh(at)oss(dot)nttdata(dot)com>
Cc: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add statistics to pg_stat_wal view for wal related parameter tuning
Date: 2020-11-13 03:32:23
Message-ID: 2020111311322320943423@sina.cn
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>Now, pg_stat_wal supports reset all informantion in WalStats
>using pg_stat_reset_shared('wal') function.
>Isn't it enough?
Yes it ok, sorry I miss this infomation.

>> 3. I do not think it's a correct describe in document for
>> 'wal_buffers_full'.

>Where should I rewrite the description? If my understanding is not
>correct, please let me know.
Sorry I have not described it clearly, because I can not understand the meaning of this
column after I read the describe in document.
And now I read the source code of walwrite and found the place where 'wal_buffers_full'
added is for a backend to wait a wal buffer which is occupied by other wal page, so the
backend flush the old page in the wal buffer(after wait it can).
So i think the origin decribe in document is not so in point, we can describe it such as
'Total number of times WAL data written to the disk because a backend yelled a wal buffer
for an advanced wal page.

Sorry if my understand is wrong.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2020-11-13 03:37:16 Re: Add docs stub for recovery.conf
Previous Message Craig Ringer 2020-11-13 03:31:24 Re: Add docs stub for recovery.conf