| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUG]: segfault during update |
| Date: | 2020-11-10 05:10:41 |
| Message-ID: | 20201110051041.m5x3ndtc66bwvvfu@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2020-11-08 12:46:44 -0500, Tom Lane wrote:
> This logic is entirely gone in v12, which confirms my instinct that
> there was something about Andres' slot-manipulation changes that
> broke this scenario.
Entirely possible :(. In my defense, it wasn't exactly obvious or
documented that the fast default code relied on this
ExecSetSlotDescriptor()...
> In v12 we end up using the junkfilter's output
> slot, which does not have a sufficiently accurate tupdesc to deal with
> an on-disk tuple rather than one constructed by the executor.
I really wonder if we ought to redesign the column default logic to
really be a property of the Attr, instead of the constraint stuff it is
now.
> So I'll go see about back-patching 20d3fe900.
Thanks.
Is it worth adding Bertrand's testcase to the regression suite in some
form?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | k.jamison@fujitsu.com | 2020-11-10 05:17:57 | RE: [Patch] Optimize dropping of relation buffers using dlist |
| Previous Message | Dilip Kumar | 2020-11-10 04:56:11 | Re: logical streaming of xacts via test_decoding is broken |