| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Phil Florent <philflorent(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgstat_report_activity() and parallel CREATE INDEX (was: Parallel index creation & pg_stat_activity) |
| Date: | 2020-10-25 05:18:36 |
| Message-ID: | 20201025051836.GC2651494@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 17, 2020 at 08:39:35AM -0700, Peter Geoghegan wrote:
> On Tue, Oct 13, 2020 at 7:26 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > 1. Disable parallelism for the index build under ExecuteTruncateGuts().
> > Nobody will mourn a performance loss from declining parallelism for an
> > empty index, but I feel like this is fixing in the wrong place.
> > 2. Make _bt_begin_parallel() and begin_parallel_vacuum() recognize the
> > debug_query_string==NULL case and reproduce it on the worker.
> > 3. Require bgworkers to set debug_query_string before entering code of vacuum,
> > truncate, etc. Logical replication might synthesize a DDL statement, or it
> > might just use a constant string.
> >
> > I tend to prefer (2), but (3) isn't bad. Opinions?
>
> I also prefer 2.
Thanks. Here is the pair of patches I plan to use. The second is equivalent
to v0; I just added a log message.
| Attachment | Content-Type | Size |
|---|---|---|
| null-debug_query_string-v1.patch | text/plain | 5.0 KB |
| worker_spi-debug_query_string-v1.patch | text/plain | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jürgen Purtz | 2020-10-25 09:40:07 | Re: [PATCH] Add section headings to index types doc |
| Previous Message | Thomas Munro | 2020-10-25 02:35:23 | Re: Collation versioning |