| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PostgresNode::backup uses spread checkpoint? |
| Date: | 2020-10-20 22:55:18 |
| Message-ID: | 20201020225518.GB1475@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 20, 2020 at 11:13:34AM -0400, David Steele wrote:
> On 10/20/20 11:01 AM, Alvaro Herrera wrote:
>> I noticed a few days ago that method backup() in PostgresNode uses
>> pg_basebackup without specifying a checkpoint mode -- and the default is
>> a spread checkpoint, which may cause any tests that use that to take
>> slightly longer than the bare minimum.
>>
>> I propose to make it use a fast checkpoint, as per the attached.
>
> +1.
+1.
- $self->host, '-p', $self->port, '--no-sync');
+ $self->host, '-p', $self->port, '-cfast', '--no-sync');
Some nits: I would recommend to use the long option name, and list
the option name and its value as two separate arguments of the
command.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2020-10-20 23:06:38 | Re: pg_upgrade: fail early if a tablespace dir already exists for new cluster version |
| Previous Message | Alvaro Herrera | 2020-10-20 22:26:21 | Re: CREATE TABLE .. PARTITION OF fails to preserve tgenabled for inherited row triggers |