Re: CREATE TABLE .. PARTITION OF fails to preserve tgenabled for inherited row triggers

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Amit Langote <amitlangote09(at)gmail(dot)com>
Subject: Re: CREATE TABLE .. PARTITION OF fails to preserve tgenabled for inherited row triggers
Date: 2020-10-20 22:26:21
Message-ID: 20201020222621.GA12830@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Oct-20, Alvaro Herrera wrote:

> > diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
> > index 511f015a86..c8d6f78da2 100644
> > --- a/src/backend/commands/tablecmds.c
> > +++ b/src/backend/commands/tablecmds.c
> > @@ -4321,6 +4321,7 @@ ATPrepCmd(List **wqueue, Relation rel, AlterTableCmd *cmd,
> > case AT_DisableTrigAll:
> > case AT_DisableTrigUser:
> > ATSimplePermissions(rel, ATT_TABLE | ATT_FOREIGN_TABLE);
> > + ATSimpleRecursion(wqueue, rel, cmd, recurse, lockmode, context);
> > pass = AT_PASS_MISC;
> > break;
> > case AT_EnableRule: /* ENABLE/DISABLE RULE variants */
>
> I'll add tests for both cases and push to all branches 11+.

Pushed this part.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-10-20 22:55:18 Re: PostgresNode::backup uses spread checkpoint?
Previous Message Justin Pryzby 2020-10-20 22:01:16 Re: CREATE TABLE .. PARTITION OF fails to preserve tgenabled for inherited row triggers