Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress

On 2018-Jun-01, Craig Ringer wrote:

> On 28 May 2018 at 15:06, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>
> > Per topic, the Pg makefiles install pg_regress (for use by extensions) and
> > htey install the isolationtester, but they don't install
> > pg_isolation_regress.
> >
> > We should install it too.

I happened to come across this thread by accident, and I tend to agree
that we need to install both isolationtester and pg_isolation_regress to
the pgxs dirs, just like we do pg_regress. I can't find that
isolationtester is installed anywhere though; maybe that changed after
you posted this. Anyway, this version of the patch installs both.

I did search for evidence in the Makefile's git log that would remove a
recipe for installing isolationtester; couldn't find anything.

> I'm wondering if I should add ISOLATION support to PGXS too, like we have
> REGRESS .

This was covered by Michael's d3c09b9b1307 a few months after you
posted.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services