Re: pg_service.conf file with unknown parameters

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_service.conf file with unknown parameters
Date: 2020-09-18 23:32:01
Message-ID: 20200918233201.GE30016@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 11, 2020 at 02:39:51PM +0200, Magnus Hagander wrote:
> Right now, pg_service.conf returns "syntax error" if it encounters a parameter
> it doesn't know about.
>
> This seems user-unfriendly, both in the error message (because it really isn't
> a syntax error) and in the behaviour itself (because it doesn't work when
> sometimes it should).
>
> For example, if I have a service file with gssencmode=disable set, that service
> file cannot be used by a psql client linked against libpq from version 10. Even
> if the behavior would be identical (since v10 doesn't have gssencmode).
>
> Is there a particular reason we (1) refuse unknown parameters in the file, and
> (2) call it a "syntax error"?
>
> The documentation just says it's "INI format" file -- though in my experience
> most other INI file parsers just ignore extra parameters included..

My guess is that because the file can contain passwords, we want to
report as little as possible on error.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2020-09-18 23:56:06 Re: Division in dynahash.c due to HASH_FFACTOR
Previous Message Bruce Momjian 2020-09-18 22:42:25 Re: Proposal of new PostgreSQL Extension - PGSpiderExt