From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
Subject: | Re: Documentation patch for backup manifests in protocol.sgml |
Date: | 2020-08-31 22:48:53 |
Message-ID: | 20200831224853.GT13613@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Aug 24, 2020 at 04:58:34PM +0900, Michael Paquier wrote:
> On Fri, Aug 21, 2020 at 06:03:32PM -0400, Bruce Momjian wrote:
> > On Tue, Aug 18, 2020 at 02:41:09PM +0200, Bernd Helmle wrote:
> >> protocol.sgml describes the protocol messages received by a BASE_BACKUP
> >> streaming command, but doesn't tell anything about the additional
> >> CopyResponse data message containing the contents of the backup
> >> manifest (if requested) after having received the tar files. So i
> >> propose the attached to give a little more detail in this paragraph.
> >
> > If someone can confirm this, I will apply it? Magnus?
>
> The reason why backup manifests are sent at the end of a base backup
> is that they include the start and stop positions of the backup (see
> caller of AddWALInfoToBackupManifest() in perform_base_backup()).
> Once this is done, an extra CopyOutResponse message is indeed sent
> within SendBackupManifest() in backup_manifest.c.
>
> So confirmed.
Patch applied through 13.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2020-08-31 23:01:10 | Re: Boundary value check in lazy_tid_reaped() |
Previous Message | Melanie Plageman | 2020-08-31 22:13:06 | Re: Avoiding hash join batch explosions with extreme skew and weird stats |