From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: some unused parameters cleanup |
Date: | 2020-08-25 17:42:29 |
Message-ID: | 20200825174229.GB20679@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 25, 2020 at 12:59:31PM -0400, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> > Here is a series of patches to remove some unused function parameters.
> > In each case, the need for them was removed by some other code changes
> > over time but the unusedness was not noticed. I have included a
> > reference to when they became unused in each case.
>
> For some of these, there's an argument for keeping the unused parameter
> for consistency with sibling functions that do use it. Not sure how
> important that is, though.
I think if they are kept for that reason, we should document that so we
know not to revisit this issue for them.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2020-08-25 17:49:51 | Re: Re: [HACKERS] Custom compression methods |
Previous Message | Andy Fan | 2020-08-25 17:37:08 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |