Re: prepared transaction isolation tests

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: prepared transaction isolation tests
Date: 2020-08-19 02:34:00
Message-ID: 20200819023400.k5zlsnccr6jv5ceg@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2020-08-18 22:24:20 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > ISTM we should just add an alternative output for disabled prepared
> > xacts, and re-add the test?
>
> I believe the buildfarm runs the isolation step with "make installcheck",
> so if you're hoping to get buildfarm coverage that way, you're mistaken.

It seems like the buildfarm ought to configure the started server with a
bunch of prepared transactions, in that case? At least going forward?

> Having said that, it'd probably be good if "make check" did run this test.

Yea. It'd at least be run when we do check-world - which at least I do
before nearly every commit.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2020-08-19 03:11:20 Re: pgsql: Fix race condition in snapshot caching when 2PC is used.
Previous Message Tom Lane 2020-08-19 02:24:20 Re: prepared transaction isolation tests

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-08-19 02:45:55 Re: Hybrid Hash/Nested Loop joins and caching results from subplans
Previous Message Tom Lane 2020-08-19 02:24:20 Re: prepared transaction isolation tests