| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Switch to multi-inserts for pg_depend |
| Date: | 2020-08-13 15:45:52 |
| Message-ID: | 20200813154552.GA30620@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Aug-13, Michael Paquier wrote:
> On Thu, Aug 13, 2020 at 05:35:14AM -0400, Alvaro Herrera wrote:
> > Next to the API definition I guess, is that dependency.h?
>
> We need something more central, see also MAX_PGATTRIBUTE_INSERT_BYTES
> and MAX_PGSHDEPEND_INSERT_BYTES. And the definition should be named
> something like MAX_CATALOG_INSERT_BYTES or such I guess.
MAX_CATALOG_INSERT_BYTES sounds decent to me. I mentioned dependency.h
because I was uncaffeinatedly thinking that this was used with API
defined there -- but in reality it's used with indexing.h functions, and
it seems to me that that file would be the place for it.
Looking at the existing contents of catalog.h, I would say it does not
fit in there.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2020-08-13 16:30:44 | Re: run pgindent on a regular basis / scripted manner |
| Previous Message | Konstantin Knizhnik | 2020-08-13 15:24:37 | jsonb, collection & postgres_fdw |