| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca> |
| Cc: | petr <petr(at)2ndquadrant(dot)com>, simon <simon(at)2ndquadrant(dot)com>, "Madan Kumar" <madankumar1993(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, craig <craig(at)2ndquadrant(dot)com>, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com>, andres <andres(at)anarazel(dot)de>, soumyadeep2007 <soumyadeep2007(at)gmail(dot)com> |
| Subject: | Re: A patch for get origin from commit_ts. |
| Date: | 2020-07-08 01:51:24 |
| Message-ID: | 20200708015124.GB18003@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 08, 2020 at 09:31:24AM +0800, movead(dot)li(at)highgo(dot)ca wrote:
> Thanks for all of that, so many details I still need to pay attention when
> submit a patch.
No problem. We are all here to learn, and nothing can be perfect, if
perfection is even possible :)
Regarding the attribute name, I was actually considering to just use
"roident" instead. This is more consistent with pglogical, and that's
also the field name we use in ReplicationState[OnDisk]. What do you
think?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | torikoshia | 2020-07-08 01:54:42 | [doc] modifying unit from characters to bytes |
| Previous Message | Michael Paquier | 2020-07-08 01:43:02 | Re: Quick doc patch |