| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Dave Cramer <davecramer(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-05 21:11:25 |
| Message-ID: | 20200705211125.GA24021@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jul-05, Daniel Gustafsson wrote:
> > On 2 Jul 2020, at 18:41, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> >
> > rebased
>
> Thanks! The new version of 0001 patch has a compiler warning due to mixed
> declarations and code:
>
> worker.c: In function ‘slot_store_data’:
> worker.c:366:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
AFAICS this is fixed in 0005. I'm going to suggest to use "git rebase
-i" so that fixes for bugs that earlier patches introduce are applied as
fix-ups in those patches; we don't need or want to see the submitter's
intermediate versions. Ideally, each submitted patch should be free of
such problems, so that we can consider each individual patch in the
series in isolation. Indeed, evidently the cfbot consider things that
way.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2020-07-05 21:28:11 | Re: Binary support for pgoutput plugin |
| Previous Message | Daniel Gustafsson | 2020-07-05 21:00:30 | Re: Online checksums verification in the backend |