| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Madan Kumar <madankumar1993(at)gmail(dot)com>, "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Álvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, soumyadeep2007(at)gmail(dot)com |
| Subject: | Re: A patch for get origin from commit_ts. |
| Date: | 2020-07-03 05:10:59 |
| Message-ID: | 20200703051059.GB1729@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 02, 2020 at 10:12:02AM +0200, Petr Jelinek wrote:
> On 02/07/2020 03:58, michael(at)paquier(dot)xyz wrote:
>> Adding a new function able to return both fields at the same time does
>> not imply that we'd remove the original one, it just implies that we
>> would be able to retrieve both fields with a single call of
>> TransactionIdGetCommitTsData(), saving from an extra CommitTsSLRULock
>> taken, etc. That's actually what pglogical does with
>> its pglogical_xact_commit_timestamp_origin() in
>> pglogical_functions.c. So adding one function able to return one
>> tuple with the two fields, without removing the existing
>> pg_xact_commit_timestamp() makes the most sense, no?
>
> Agreed, sounds reasonable.
Thanks. Movead, please note that the patch is waiting on author?
Could you send an update if you think that those changes make sense?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey V. Lepikhov | 2020-07-03 05:15:46 | Re: [POC] Fast COPY FROM command for the table with foreign partitions |
| Previous Message | Michael Paquier | 2020-07-03 05:03:46 | Re: Read access for pg_monitor to pg_replication_origin_status view |