Re: Missing some ifndef FRONTEND at the top of logging.c and file_utils.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Missing some ifndef FRONTEND at the top of logging.c and file_utils.c
Date: 2020-06-26 00:59:30
Message-ID: 20200626005930.GB1504@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 25, 2020 at 11:15:03AM +0200, Daniel Gustafsson wrote:
> That makes sense, logging.c and file_utils.c are indeed only part of
> libpgcommon.a and should only be compiled for frontend.

Thanks. This list is provided by OBJS_FRONTEND in
src/common/Makefile, and pgcommonfrontendfiles in Mkvcbuild.pm. Let's
see if others have comments, as it just looks like something that was
forgotten in bf5bb2e and fc9a62a when this code was moved to
src/common/. If there are no objections, I'll revisit that some time
next week and fix it on HEAD.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-06-26 01:03:13 Re: Failures with installcheck and low work_mem value in 13~
Previous Message Peter Geoghegan 2020-06-26 00:44:40 Re: xid wraparound danger due to INDEX_CLEANUP false