Re: Assertion failure in pg_copy_logical_replication_slot()

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Assertion failure in pg_copy_logical_replication_slot()
Date: 2020-06-24 14:58:47
Message-ID: 20200624145847.GA18281@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Jun-24, Fujii Masao wrote:

> > I think the errcode is a bit bogus considering the new case.
> > IMO ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE is more appropriate.
>
> Agreed. So I updated the patch so this errcode is used instead.
> Patch attached.

LGTM.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-06-24 15:04:22 Re: pg_resetwal --next-transaction-id may cause database failed to restart.
Previous Message Alvaro Herrera 2020-06-24 14:58:08 Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762