Re: TAP tests and symlinks on Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP tests and symlinks on Windows
Date: 2020-06-23 10:55:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Jun 17, 2020 at 04:44:34PM +0900, Michael Paquier wrote:
> Okay. This could be a problem as jacana is proving to have good
> coverage AFAIK. So it looks like we are really heading in the
> direction is still skipping the test if there is no support for
> symlink in the environment. At least that makes less diffs in the
> patch.

I have implemented a patch based on the feedback received that does
the following, tested with all three patterns (MSVC only on Windows):
- Assume that all non-Windows platform have a proper symlink
implementation for perl.
- If on Windows, check for the presence of Win32::Symlink:
-- If the module is not detected, skip the tests not supported.
-- If the module is detected, run them.

I have added this patch to the next commit fest:


Attachment Content-Type Size
win32-readlink-tap-v2.patch text/x-diff 5.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2020-06-23 11:05:03 Re: Parallel Seq Scan vs kernel read ahead
Previous Message Tomas Vondra 2020-06-23 10:18:31 Re: Resetting spilled txn statistics in pg_stat_replication