|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>|
|Cc:||Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: TAP tests and symlinks on Windows|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Sat, Jun 13, 2020 at 03:00:54PM +0900, Michael Paquier wrote:
> My take would be to actually enforce that as a requirement for 14~ if
> that works reliably, and of course not backpatch that change as that's
> clearly an improvement and not a bug fix. It would be good to check
> the status of each buildfarm member first though. And I would need to
> also check my own stuff to begin with..
So, I have been looking at that. And indeed as Peter said we are
visibly missing one call to perl2host in 010_pg_basebackup.pl.
Another thing I spotted is that Win32::Symlink does not allow to
detect properly if a path is a symlink using -l, causing one of the
tests of pg_basebackup to fail when checking if a tablespace path has
been updted. It would be good to get more people to test this patch
with different environments than mine. I am also adding Andrew
Dunstan in CC as the owner of the buildfarm animals running currently
TAP tests for confirmation about the presence of Win32::Symlink
there as I am afraid it would cause failures: drongo, fairywen,
jacana and bowerbird.
|Next Message||Michael Paquier||2020-06-15 06:35:41||Re: Read access for pg_monitor to pg_replication_origin_status view|
|Previous Message||Amit Kapila||2020-06-15 06:20:04||Re: Transactions involving multiple postgres foreign servers, take 2|