| From: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: TAP tests and symlinks on Windows |
| Date: | 2020-06-16 08:10:23 |
| Message-ID: | CAC+AXB2ghx-RBggkmz9fHVoRs0u4B3HvYkx3tSFgwthHX=kmhg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 15, 2020 at 8:23 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Another thing I spotted is that Win32::Symlink does not allow to
> detect properly if a path is a symlink using -l, causing one of the
> tests of pg_basebackup to fail when checking if a tablespace path has
> been updted. It would be good to get more people to test this patch
> with different environments than mine. I am also adding Andrew
> Dunstan in CC as the owner of the buildfarm animals running currently
> TAP tests for confirmation about the presence of Win32::Symlink
> there as I am afraid it would cause failures: drongo, fairywen,
> jacana and bowerbird.
>
This patch works on my Windows 10 / Visual Studio 2019 / Perl 5.30.2
machine.
Regards,
Juan José Santamaría Flecha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-06-16 08:16:21 | snowball ASCII stemmer configuration |
| Previous Message | tsunakawa.takay@fujitsu.com | 2020-06-16 08:01:21 | RE: I'd like to discuss scaleout at PGCon |