Re: pg_upgrade fails with non-standard ACL

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Cc: Arthur Zakirov <zaartur(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade fails with non-standard ACL
Date: 2020-06-08 16:31:26
Message-ID: 20200608163126.GA27318@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2020-Jun-08, Anastasia Lubennikova wrote:

> In this version I rebased test patches,  added some more comments, fixed
> memory allocation issue and also removed code that handles ACLs on
> languages. They require a lot of specific handling, while I doubt that their
> signatures, which consist of language name only, are subject to change in
> any future versions.

I'm thinking what's a good way to have a test that's committable. Maybe
it would work to add a TAP test to pg_upgrade that runs initdb, does a
few GRANTS as per your attachment, then runs pg_upgrade? Currently the
pg_upgrade tests are not TAP ... we'd have to revive
(Some progress was already made on the buildfarm front to permit this)

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-06-08 16:39:32 Re: Getting ERROR with FOR UPDATE/SHARE for partitioned table.
Previous Message Alvaro Herrera 2020-06-08 16:21:44 Re: should CREATE INDEX ON partitioned_table call PreventInTransactionBlock() ?