Re: Incorrect comment in be-secure-openssl.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect comment in be-secure-openssl.c
Date: 2020-05-31 06:54:15
Message-ID: 20200531065415.GA2008@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 29, 2020 at 02:38:53PM +0900, Michael Paquier wrote:
> Indeed, looks good to me. I'll go fix, ust let's wait and see first
> if others have any comments.

Actually, I was reading again the new sentence, and did not like its
first part. Here is a rework that looks much better to me:
* Load hardcoded DH parameters.
*
- * To prevent problems if the DH parameter files don't even exist, we
- * can load hardcoded DH parameters supplied with the backend.
+ * If DH parameters cannot be loaded from a specified file, we can load
+ * the hardcoded DH parameters supplied with the backend to prevent
+ * problems.

Daniel, is that fine for you?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Антон Пацев 2020-05-31 07:43:45 Proposal: remove string "contains errors; unaffected changes were applied"
Previous Message Michael Paquier 2020-05-31 02:52:15 Re: OpenSSL 3.0.0 compatibility