| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem with logical replication |
| Date: | 2020-05-16 09:20:46 |
| Message-ID: | 20200516092046.GG212736@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 15, 2020 at 08:48:53AM -0300, Euler Taveira wrote:
> On Fri, 15 May 2020 at 02:47, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Agreed. I don't think either that we need to update this comment. I
>> was playing with this patch and what you have here looks fine by me.
>> Two nits: the extra parenthesis in the assert are not necessary, and
>> the indentation had some diffs. Tom has just reindented the whole
>> tree, so let's keep things clean.
>
> LGTM.
Thanks for double-checking. Applied and back-patched down to 10
then.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2020-05-16 11:39:18 | Re: calling procedures is slow and consumes extra much memory against calling function |
| Previous Message | legrand legrand | 2020-05-16 09:01:35 | Re: Is it useful to record whether plans are generic or custom? |