Re: Potentially misleading name of libpq pass phrase hook

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Potentially misleading name of libpq pass phrase hook
Date: 2020-05-16 00:08:22
Message-ID: 20200516000822.GA7519@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-May-15, Magnus Hagander wrote:

> On Thu, May 14, 2020 at 3:03 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

> > Since we haven't shipped this there is still time to rename, which
> > IMO is the right way forward. PQsslKeyPassHook_<library>_type would
> > be one option, but perhaps there are better alternatives?
>
> ISTM this should be renamed yeah -- and it should probably go on the open
> item lists, and with the schedule for the beta perhaps dealt with rather
> urgently?

Seems easy enough to do! +1 on Daniel's suggested renaming.

CCing Andrew as committer.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-05-16 00:16:41 Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format
Previous Message Alvaro Herrera 2020-05-15 23:34:46 Re: pg_stat_wal_receiver and flushedUpto/writtenUpto