| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add "-Wimplicit-fallthrough" to default flags |
| Date: | 2020-05-13 16:04:40 |
| Message-ID: | 20200513160440.GA8414@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2020-May-13, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> >> I fear that is going to mean that we revert this patch.
>
> > Or we can filter-out the -Wimplicit-fallthrough, or change to level 3,
> > for bison-emitted files.
>
> Let's just go to level 3 overall (and revert the changes you made for
> level 4 compliance --- they're more likely to cause back-patching
> pain than do anything useful).
Ok.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-05-13 16:25:45 | pgsql: Adjust walsender usage of xlogreader, simplify APIs |
| Previous Message | Tom Lane | 2020-05-13 15:34:21 | Re: Add "-Wimplicit-fallthrough" to default flags |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2020-05-13 16:05:44 | ldap tls test fails in some environments |
| Previous Message | Andy Fan | 2020-05-13 16:02:42 | Re: [PATCH] Keeps tracking the uniqueness with UniqueKey |