| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, andres(at)anarazel(dot)de, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: 2pc leaks fds |
| Date: | 2020-05-11 16:25:54 |
| Message-ID: | 20200511162554.GA10483@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Antonin, thanks for the review.
On 2020-May-11, Antonin Houska wrote:
> While looking at the changes, I've noticed a small comment issue in the
> XLogReaderRoutine structure definition:
>
> * "tli_p" is an input/output argument. XLogRead() uses it to pass the
>
> The XLogRead() function has been renamed to WALRead() in 0dc8ead4. (This
> incorrect comment was actually introduced by that commit.)
Ah. I'll fix this, thanks for pointing it out.
(It might be that the TLI situation can be improved with some callback,
too.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2020-05-11 17:21:22 | Re: new heapcheck contrib module |
| Previous Message | Amit Langote | 2020-05-11 14:41:30 | Re: making update/delete of inheritance trees scale better |