From: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Postgres Windows build system doesn't work with python installed in Program Files |
Date: | 2020-05-01 09:48:17 |
Message-ID: | 20200501124817.0f253187@antares.wagner.home |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
В Fri, 1 May 2020 17:52:15 +0900
Michael Paquier <michael(at)paquier(dot)xyz> пишет:
> On Thu, Apr 30, 2020 at 03:06:08PM +0300, Victor Wagner wrote:
> > Fix is very simple, see attach.
> >
> > Patch is made against REL_12_STABLE, but probably applicable to
> > other versions as well.
>
> Indeed, thanks.
>
> > my $pythonprog = "import sys;print(sys.prefix);"
> > .
> > "print(str(sys.version_info[0])+str(sys.version_info[1]))"; my
> > $prefixcmd =
> > - $solution->{options}->{python} . "\\python -c
> > \"$pythonprog\"";
> > + '"' . $solution->{options}->{python} . "\\python\"
> > -c \"$pythonprog\""; my $pyout = `$prefixcmd`;
> > die "Could not query for python version!\n" if $?;
> > my ($pyprefix, $pyver) = split(/\r?\n/, $pyout);
>
> This reminds me of ad7595b. Wouldn't it be better to use qq() here?
Maybe. But probably original author of this code was afraid of using
too long chain of ->{} in the string substitution.
So, I left this style n place.
Nonetheless, using qq wouldn't save us from doubling backslashes.
--
From | Date | Subject | |
---|---|---|---|
Next Message | Atsushi Torikoshi | 2020-05-01 10:10:23 | pg_stat_reset_slru(name) doesn't seem to work as documented |
Previous Message | Michael Paquier | 2020-05-01 08:52:15 | Re: Postgres Windows build system doesn't work with python installed in Program Files |