Re: Setting min/max TLS protocol in clientside libpq

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, cary huang <hcary328(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Setting min/max TLS protocol in clientside libpq
Date: 2020-04-25 00:29:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Apr 24, 2020 at 02:03:04PM +0200, Daniel Gustafsson wrote:
> That was brought up by Michael in the thread, but none of us followed up on it
> it seems. The current name was chosen to be consistent with the already
> existing ssl* client-side settings, but I don't really have strong opinions on
> if that makes sense or not. Perhaps use ssl_m{in|max}_protocolversion to make
> it more readable?

There was no hard push in favor of this comment so I did not insist,
but I am not wedded to the existing connection parameter names.

- {"sslminprotocolversion", "PGSSLMINPROTOCOLVERSION", NULL, NULL,
+ {"ssl_min_protocolversion", "PGSSLMINPROTOCOLVERSION", NULL, NULL,
Shouldn't that actually be "ssl_min_protocol_version" with one extra

> The attached renames the userfacing setting, but keeps the environment variable
> without underscores as most settings have env vars without underscores.

There are two in this case: PG_COLOR and PG_COLORS. For readability
it could make sense to use something like PG_SSL_MIN_PROTOCOL_VERSION
or PGSSL_MIN_PROTOCOL_VERSION, but like Daniel I'd rather keep the env
variables without underscores.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2020-04-25 01:22:34 Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays
Previous Message David G. Johnston 2020-04-25 00:19:28 Re: psql - pager support - using invisible chars for signalling end of report