| From: | "movead(dot)li(at)highgo(dot)ca" <movead(dot)li(at)highgo(dot)ca> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | wal_insert_waring_issue |
| Date: | 2020-03-30 08:58:56 |
| Message-ID: | 2020033016585362994827@highgo.ca |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello hackers,
I find a small issue in XLogInsertRecord() function: it checks whether it's able
to insert a wal by XLogInsertAllowed(), when refused it reports an error "cannot
make new WAL entries during recovery".
I notice that XLogInsertAllowed() reject to insert a wal record not only sometimes
in recovery status, but also after a 'shutdown' checkpoint. So if it's better to
add an error report message "cannot make new WAL entries during shutdown" which I
make a patch attached.
Best regards,
Highgo Software (Canada/China/Pakistan)
URL : www.highgo.ca
EMAIL: mailto:movead(dot)li(at)highgo(dot)ca
| Attachment | Content-Type | Size |
|---|---|---|
| wal_insert_waring_issue.patch | application/octet-stream | 600 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-03-30 09:01:53 | Re: error context for vacuum to include block number |
| Previous Message | Michael Paquier | 2020-03-30 08:15:59 | Re: Possible copy and past error? (\usr\backend\commands\analyze.c) |