| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Possible copy and past error? (\usr\backend\commands\analyze.c) |
| Date: | 2020-03-30 08:15:59 |
| Message-ID: | 20200330081559.GH43995@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 28, 2020 at 07:48:22AM -0300, Ranier Vilela wrote:
> I completely disagree. My tools have proven their worth, including finding
> serious errors in the code, which fortunately have been fixed by other
> committers.
FWIW, I think that the rule to always take Coverity's reports with a
pinch of salt applies for any report.
> When issuing this alert, the tool does not value judgment regarding
> performance or optimization, but it does an excellent job of finding
> similar patterns in adjacent lines, and the only thing it asked for was to
> be asked if this was really the case. original author's intention.
The code context matters a lot, but here let's leave this code alone.
There is nothing wrong with it.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | movead.li@highgo.ca | 2020-03-30 08:58:56 | wal_insert_waring_issue |
| Previous Message | Etsuro Fujita | 2020-03-30 08:15:56 | Re: Asynchronous Append on postgres_fdw nodes. |