| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Liudmila Mantrova <l(dot)mantrova(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru |
| Subject: | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2020-03-30 01:56:48 |
| Message-ID: | 20200330015648.GA43995@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 27, 2020 at 07:47:29AM +0900, Michael Paquier wrote:
> On Thu, Mar 26, 2020 at 06:56:36PM -0300, Alvaro Herrera wrote:
>> I don't think any such cleanup should hamper the patch at hand anyway.
>
> I don't think either, so I would do the split for the archive routines
> at least. It still feels strange to me to have a different routine
> name for the frontend-side of RestoreArchivedFile(). That's not
> really consistent with the current practice we have palloc() & co, as
> well as the sync routines.
Okay. Hearing nothing, I have rebased the patch set this morning,
improving some comments and the code format while on it. I would like
to commit both 0001 (creation of xlogarchiver.h) and 0002 attached in
the next couple of days. If you have an objection, please feel free.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Move-routines-of-xlogarchive.c-into-their-own-hea.patch | text/x-diff | 5.2 KB |
| v5-0002-Add-c-restore-target-wal-to-pg_rewind.patch | text/x-diff | 23.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2020-03-30 02:04:59 | Re: Berserk Autovacuum (let's save next Mandrill) |
| Previous Message | Tomas Vondra | 2020-03-30 01:44:42 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |