| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pengzhou Tang <ptang(at)pivotal(dot)io> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Jesse Zhang <sbjesse(at)gmail(dot)com>, Richard Guo <riguo(at)pivotal(dot)io>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Subject: | Re: Parallel grouping sets |
| Date: | 2020-03-19 02:09:14 |
| Message-ID: | 20200319020914.zkcjpm5r4yj7umqx@development |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
unfortunately this got a bit broken by the disk-based hash aggregation,
committed today, and so it needs a rebase. I've started looking at the
patch before that, and I have it rebased on e00912e11a9e (i.e. the
commit before the one that breaks it).
Attached is the rebased patch series (now broken), with a couple of
commits with some minor cosmetic changes I propose to make (easier than
explaining it on a list, it's mostly about whitespace, comments etc).
Feel free to reject the changes, it's up to you.
I'll continue doing the review, but it'd be good to have a fully rebased
version.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-All-grouping-sets-do-their-own-sorting.patch | text/plain | 34.4 KB |
| 0002-fixes.patch | text/plain | 5.9 KB |
| 0003-fix-a-numtrans-bug.patch | text/plain | 1.4 KB |
| 0004-Reorganise-the-aggregate-phases.patch | text/plain | 70.3 KB |
| 0005-fix.patch | text/plain | 6.9 KB |
| 0006-Parallel-grouping-sets.patch | text/plain | 58.2 KB |
| 0007-fix.patch | text/plain | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-03-19 02:24:26 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |
| Previous Message | Amit Langote | 2020-03-19 01:02:14 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |