Re: Autovacuum on partitioned table

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: yuzuko <yuzukohosoya(at)gmail(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu>
Subject: Re: Autovacuum on partitioned table
Date: 2020-03-18 01:49:10
Message-ID: 20200318014910.GA19400@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-Mar-18, yuzuko wrote:

> > I think if we analyze partition tree in order from leaf partitions
> > to root table, this problem can be fixed.
> > What do you think about it?
>
> Attach the new patch fixes the above problem.

Thanks for the new version.

I'm confused about some error messages in the regression test when a
column is mentioned twice, that changed from mentioning the table named
in the vacuum command, to mentioning the first partition. Is that
because you changed an lappend() to lcons()? I think you do this so
that the counters accumulate for the topmost parent that will be
processed at the end. I'm not sure I like that too much ... I think
that needs more thought.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-03-18 01:56:08 Re: [PATCH] Erase the distinctClause if the result is unique by definition
Previous Message Alvaro Herrera 2020-03-18 01:47:54 Re: WIP: WAL prefetch (another approach)