Re: error context for vacuum to include block number

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: error context for vacuum to include block number
Date: 2020-01-22 01:17:52
Message-ID: 20200122011752.GI26045@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 21, 2020 at 05:54:59PM -0300, Alvaro Herrera wrote:
> > On Tue, Jan 21, 2020 at 03:11:35PM +0900, Masahiko Sawada wrote:
> > > Some of them conflicts with the current HEAD(62c9b52231). Please rebase them.
> >
> > Sorry, it's due to other vacuum patch in this branch.
> >
> > New patches won't conflict, except for the 0005, so I renamed it for cfbot.
> > If it's deemed to be useful, I'll make a separate branch for the others.
>
> I think you have to have some other patches applied before these,
> because in the context lines for some of the hunks there are
> double-slash comments.

And I knew that, so (re)tested that the extracted patches would apply, but it
looks like maybe the patch checker is less smart (or more strict) than git, so
it didn't work after all.

3rd attempt (sorry for the noise).

Attachment Content-Type Size
v12-0001-vacuum-errcontext-to-show-block-being-processed.patch text/x-diff 3.9 KB
v12-0002-add-errcontext-callback-in-lazy_vacuum_heap-too.patch text/x-diff 1.9 KB
v12-0003-Add-vacrelstats.stage-and-distinct-context-messa.patch text/x-diff 2.1 KB
v12-0004-errcontext-for-lazy_vacuum_index.patch text/x-diff 2.4 KB
v12-0005-Avoid-extra-calls-like-GetRelationName.patch text/x-diff 7.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-01-22 01:27:47 Re: doc: alter table references bogus table-specific planner parameters
Previous Message Karl O. Pinc 2020-01-22 01:03:38 Re: Patch to document base64 encoding