| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: error context for vacuum to include block number |
| Date: | 2020-01-22 02:19:54 |
| Message-ID: | 20200122021954.GA5885@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jan-21, Justin Pryzby wrote:
> And I knew that, so (re)tested that the extracted patches would apply, but it
> looks like maybe the patch checker is less smart (or more strict) than git, so
> it didn't work after all.
Honestly, I think we should be scared of a patch applier that ignored
differences in context lines. After all, that's why those context lines
are there -- so that they provide additional location cues for the lines
being modified. If you allow random other lines to be there, you could
be inserting stuff in arbitrarily erroneous places.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-01-22 02:23:31 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Amit Kapila | 2020-01-22 02:18:04 | Re: [HACKERS] Block level parallel vacuum |